Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       146           
  Branches        37        37           
=========================================
  Hits           146       146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496657b...b21b748. Read the comment docs.

@sidharthv96 Thanks for your PR 🙏 At the moment I do not care so much about types, so I will review your changes a little bit later. Furthermore what about all those new dev dependencies? Could you please explain why you added them? Thanks.

Hi @kr1sp1n , I've added only a single dependency json-schema-to-typescript which converts the json schemas that you have to typescript classes. The diff you see in the yarn.lock files are automatic updates by yarn itself, which can be ignored.

Types are extremely important to our use case and if they are added in the main library, it will be a huge help for us.
As all the interfaces are generated automatically from the schema and are backward compatible with the existing Options type, it'll be easy for review.

You can also run node scripts/gen-types.js to verify the correctness of types.

Thanks for making node-vault!

Is there any update on this @kr1sp1n? We'd also really appreciate these missing types being added and released!

Hey @sidharthv96 -> do you mind resolving the conflicts? <3

@sidharthv96 another ping ❤️