Add raftJoin and recovery options to init - #196
Open
naimo84 wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
lgtm |
Sorry, something went wrong.
aviadhahami
requested changes
May 11, 2023
aviadhahami
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
please fix PR issues
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Requested changes must be addressed to merge this pull request.
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At work we're using two vaults. One for autounseal and one for the "real data".
The one for autounseal can be initialized as usual with secret_shares, the data one has to be initalized with recovery_shares options. This one is also a RaftCluster, so I added raft join.
https://www.vaultproject.io/api-docs/system/storage/raft
https://www.vaultproject.io/api/system/init#recovery_shares
Greets,
Benjamin