FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: pass kubernetesPath into the mustache path context by emmayusufu · Pull Request #302 · nodevault/node-vault · GitHub

/ node-vault Public

fix: pass kubernetesPath into the mustache path context #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmayusufu wants to merge 1 commit into
base: master
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 1 Checks 0 Files changed
Open

fix: pass kubernetesPath into the mustache path context #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 3 additions & 2 deletions src/index.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,9 @@ module.exports = (config = {}) => {
client[name] = (args = {}) => {
const options = { ...config.requestOptions, ...args.requestOptions };
options.method = conf.method;
// replace args in path.
options.path = mustache.render(conf.path, args);
// replace args in path. kubernetesPath lives on the client (not in
// args), so inject it into the template context; args still win.
options.path = mustache.render(conf.path, { kubernetesPath: client.kubernetesPath, ...args });
// no schema object -> no validation
if (!conf.schema) {
if (options.method === 'POST' || options.method === 'PUT') {
Expand Down
66 changes: 66 additions & 0 deletions test/unit.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,72 @@ describe('node-vault', () => {
})
.catch(done);
});

it('should default the kubernetes mount point in kubernetesLogin path', (done) => {
const request = sinon.stub();
const response = sinon.stub();
response.statusCode = 200;
response.body = { auth: { client_token: 'test-token' } };
request.returns({
then(fn) {
return fn(response);
},
catch(fn) {
return fn();
},
});

const vault = index({
endpoint: 'http://localhost:8200',
token: '123',
'request-promise': {
defaults: () => request,
},
});

vault.kubernetesLogin({ role: 'my-role', jwt: 'my-jwt' })
.then(() => {
request.should.have.calledOnce();
const uri = request.firstCall.args[0].uri;
uri.should.equal('http://localhost:8200/v1/auth/kubernetes/login');
uri.should.not.contain('/auth//login');
done();
})
.catch(done);
});

it('should use a custom kubernetesPath in kubernetesLogin path', (done) => {
const request = sinon.stub();
const response = sinon.stub();
response.statusCode = 200;
response.body = { auth: { client_token: 'test-token' } };
request.returns({
then(fn) {
return fn(response);
},
catch(fn) {
return fn();
},
});

const vault = index({
endpoint: 'http://localhost:8200',
token: '123',
kubernetesPath: 'k8s-prod',
'request-promise': {
defaults: () => request,
},
});

vault.kubernetesLogin({ role: 'my-role', jwt: 'my-jwt' })
.then(() => {
request.should.have.calledOnce();
const uri = request.firstCall.args[0].uri;
uri.should.equal('http://localhost:8200/v1/auth/k8s-prod/login');
done();
})
.catch(done);
});
});

describe('client', () => {
Expand Down
Back | FazBrowse Home | New Git URL