Fix teardown NRE/ODE in ReplicationConnection's SendStatusUpdate - #6630
Open
Hawxy wants to merge 1 commit into
Open
Fix teardown NRE/ODE in ReplicationConnection's SendStatusUpdate#6630Hawxy wants to merge 1 commit into
Hawxy wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the replication connection gets torn down whilst SendStatusUpdate is in-flight, you get to spin the wheel on getting an NRE or ODE which isn't ideal:
This fixes it so OperationCanceledException and InvalidOperationException are the only exceptions that show up and should match developer expectations a bit better.