fix(did-you-mean): succeed if cwd is not a package - #3747
Merged
wraithgar merged 1 commit intoSep 13, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nlf
approved these changes
Sep 13, 2021
nlf
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
good fix!
Sorry, something went wrong.
wraithgar
force-pushed
the
gar/dym-no-pkg
branch
from
ad30872 to
13d2d5e
Compare
September 13, 2021 18:33
The did-you-mean code was trying to parse a local package.json to suggest scripts and bins, which was causing an exception if you ran npm outside of a directory with a valid package.json. This fixes that. PR-URL: #3747 Credit: @wraithgar Close: #3747 Reviewed-by: @nlf
wraithgar
force-pushed
the
gar/dym-no-pkg
branch
from
13d2d5e to
5974397
Compare
September 13, 2021 19:35
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The did-you-mean code was trying to parse a local package.json to
suggest scripts and bins, which was causing an exception if you ran npm
outside of a directory with a valid package.json.
This fixes that.