fix: use local font provider by alexdln · Pull Request #2803 · npmx-dev/npmx.dev · GitHub

🧭 Context

The Geist Mono font recently broke. Because of this, ligatures (-->, ==, !=, ..., --, etc.) no longer displayed correctly. This has already been fixed - google/fonts#10540 - but due to several other services and caching issues font continues to be broken.

📚 Description

I used local fonts, as they are already configured in our repository. This will be more stable and should not impact performance overall, as users connect to our servers and wit ha few locations

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	May 26, 2026 3:08pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	May 26, 2026 3:08pm
npmx-lunaria	Ignored		May 26, 2026 3:08pm

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

nuxt.config.ts updates "Geist" and "Geist Mono" font entries to use provider: 'local', numeric weights (Geist: [400, 500, 600]; Geist Mono: [400, 500]), retains global: true, and removes prior preload settings.

Changes

Geist Font Configuration

Layer / File(s)	Summary
Font entries: Geist and Geist Mono nuxt.config.ts	Geist now uses provider: 'local' and numeric weights: [400, 500, 600] with global: true and no preload. Geist Mono now uses provider: 'local' and numeric weights: [400, 500] with global: true and no preload.

🚥 Pre-merge checks | ✅ 4 ✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, explaining the context (Geist Mono font breakage), rationale (switching to local fonts), and expected benefits (stability).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title 'fix: use local font provider' directly describes the main change—switching to local font loading to resolve the Geist Mono ligature display issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Why ttf, and why not the npm provider?

Hmm, I don't see much reasons in adding a package. It seems like the font should remain unchanged (and auto package updates could also break in this case)

But honestly, these fonts simply already existed. We even used them before due to the specifics of previous og generation (now only for storybook)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

nuxt.config.ts (1)
276-315: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Local provider should resolve Geist/Geist Mono without src; review IBM Plex provider consistency.

provider: 'local' without src is aligned with @nuxt/fonts’ local provider behaviour (auto-discovery from public/ with filename-derived weight/style). This repo contains public/fonts/Geist-{Regular,Medium,SemiBold}.ttf (400/500/600) and public/fonts/GeistMono-{Regular,Medium,Bold}.ttf (400/500), so the configured Geist/Geist Mono entries should resolve correctly.

IBM Plex Sans Arabic still lacks provider: 'local' (and keeps weights: ['400','500','600']), so it may continue using the default/remote provider. If the intent is to keep this fully local, set provider: 'local' and ensure matching IBM Plex font files exist and follow the expected naming convention.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@nuxt.config.ts` around lines 276 - 315, The font families block defines Geist
and Geist Mono correctly using provider: 'local' and should resolve to
public/fonts/Geist-{Regular,Medium,SemiBold}.ttf and
public/fonts/GeistMono-{Regular,Medium,Bold}.ttf, but the "IBM Plex Sans Arabic"
entry is missing provider: 'local' and will fall back to a remote provider; add
provider: 'local' to the "IBM Plex Sans Arabic" family entry in the families
array (and keep weights: ['400','500','600']) and ensure matching font files
exist in public/fonts following the `@nuxt/fonts` local naming convention (e.g.
IBMPlexSansArabic-{WeightName}.ttf) so the local provider can auto-discover
them.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@nuxt.config.ts`:
- Around line 276-315: The font families block defines Geist and Geist Mono
correctly using provider: 'local' and should resolve to
public/fonts/Geist-{Regular,Medium,SemiBold}.ttf and
public/fonts/GeistMono-{Regular,Medium,Bold}.ttf, but the "IBM Plex Sans Arabic"
entry is missing provider: 'local' and will fall back to a remote provider; add
provider: 'local' to the "IBM Plex Sans Arabic" family entry in the families
array (and keep weights: ['400','500','600']) and ensure matching font files
exist in public/fonts following the `@nuxt/fonts` local naming convention (e.g.
IBMPlexSansArabic-{WeightName}.ttf) so the local provider can auto-discover
them.

ℹ️ Review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6f04d1e-06b4-4d09-9fd6-46da762a25a2

📥 Commits

Reviewing files that changed from the base of the PR and between e9b15e5 and a2dd9cd.

📒 Files selected for processing (1)

nuxt.config.ts

🧹 Nitpick comments (1)

nuxt.config.ts (1)
284-289: ⚡ Quick win

Harmonise weights types for discrete font weights

@nuxt/fonts supports weights as numeric arrays and also string forms (commonly for variable-range syntax like '100 900'), so the current numbers-vs-strings mix is likely acceptable. For discrete weights though, keeping the representation consistent improves readability/maintainability—use number weights for “IBM Plex Sans Arabic” to match Geist.
♻️ Suggested fix
{
  name: 'IBM Plex Sans Arabic',
  weights: [400, 500, 600],
  global: true,
  subsets: ['arabic'],
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@nuxt.config.ts` around lines 284 - 289, The fonts entry uses mixed types for
discrete font weights—update the "IBM Plex Sans Arabic" font configuration to
use numeric weights (e.g., change any string weight entries to numbers like 400,
500, 600) to match the "Geist" entry and improve consistency; locate the IBM
Plex Sans Arabic object in nuxt.config.ts (the font entry with name "IBM Plex
Sans Arabic", provider, subsets/global keys) and replace the weights array with
numeric values such as [400, 500, 600].

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@nuxt.config.ts`:
- Around line 284-289: The fonts entry uses mixed types for discrete font
weights—update the "IBM Plex Sans Arabic" font configuration to use numeric
weights (e.g., change any string weight entries to numbers like 400, 500, 600)
to match the "Geist" entry and improve consistency; locate the IBM Plex Sans
Arabic object in nuxt.config.ts (the font entry with name "IBM Plex Sans
Arabic", provider, subsets/global keys) and replace the weights array with
numeric values such as [400, 500, 600].

ℹ️ Review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eba65189-dbbe-4b47-87fe-ead44bded182

📥 Commits

Reviewing files that changed from the base of the PR and between a2dd9cd and 372f0aa.

📒 Files selected for processing (1)

nuxt.config.ts

Actionable comments posted: 1

🧹 Nitpick comments (1)

nuxt.config.ts (1)
280-291: 💤 Low value

Consider standardising weight values to numeric arrays.

The font configurations use inconsistent weight value types:

Lines 280, 286: Numeric arrays ([400, 500, 600], [400, 500])

Line 291: String array (['400', '500', '600'])

For better type consistency and to follow TypeScript best practices, consider standardising all font weight arrays to use the same type (preferably numeric).
♻️ Suggested standardisation
       {
         name: 'IBM Plex Sans Arabic',
-        weights: ['400', '500', '600'],
+        weights: [400, 500, 600],
         global: true,
         subsets: ['arabic'],
       },
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@nuxt.config.ts` around lines 280 - 291, The font config for "IBM Plex Sans
Arabic" uses string weight values while others use numbers—standardise all font
weight arrays to numeric types (e.g., change weights: ['400','500','600'] to
weights: [400, 500, 600]) to ensure consistent typing; update the weights entry
on the "IBM Plex Sans Arabic" object and verify other font objects like "Geist
Mono" and the first font block use numeric arrays so TypeScript types for the
font config remain uniform.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@nuxt.config.ts`:
- Line 286: Update the Nuxt fonts configuration for the Geist Mono entry:
replace the incorrect property name "weight" with the correct "weights" and set
it to the same array [400, 500]; locate the Geist Mono font block in nuxt config
(search for "Geist Mono" or the fonts module configuration and the "weight" key)
and change weight: [400, 500] to weights: [400, 500] so the `@nuxt/fonts` module
will register and load the specified font weights.

---

Nitpick comments:
In `@nuxt.config.ts`:
- Around line 280-291: The font config for "IBM Plex Sans Arabic" uses string
weight values while others use numbers—standardise all font weight arrays to
numeric types (e.g., change weights: ['400','500','600'] to weights: [400, 500,
600]) to ensure consistent typing; update the weights entry on the "IBM Plex
Sans Arabic" object and verify other font objects like "Geist Mono" and the
first font block use numeric arrays so TypeScript types for the font config
remain uniform.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4b0003b2-6524-4197-9d1d-2226d19b3c92

📥 Commits

Reviewing files that changed from the base of the PR and between 372f0aa and 79cba81.

📒 Files selected for processing (1)

nuxt.config.ts

are we deliberately disabling preload?

jsdoc says this is true by default 👀

Co-authored-by: Daniel Roe <daniel@roe.dev>

chore: use local fonts

e9b15e5

mootari reviewed May 26, 2026

View reviewed changes

vercel Bot deployed to Preview – npmx.dev May 26, 2026 13:57 View deployment

chore: change fonts configuration

a2dd9cd

vercel Bot deployed to Preview – npmx.dev May 26, 2026 14:23 View deployment

coderabbitai Bot reviewed May 26, 2026

View reviewed changes

chore: use weights group for geist font

372f0aa

vercel Bot deployed to Preview – npmx.dev May 26, 2026 14:29 View deployment

coderabbitai Bot reviewed May 26, 2026

View reviewed changes

chore: use weights group for geist font

79cba81

vercel Bot deployed to Preview – npmx.dev May 26, 2026 14:35 View deployment

coderabbitai Bot reviewed May 26, 2026

View reviewed changes

Comment thread nuxt.config.ts Outdated

danielroe reviewed May 26, 2026

View reviewed changes

Comment thread nuxt.config.ts Outdated

chore: apply suggestion

f45bf40

Co-authored-by: Daniel Roe <daniel@roe.dev>

vercel Bot deployed to Preview – npmx.dev May 26, 2026 15:08 View deployment

danielroe approved these changes May 26, 2026

View reviewed changes

danielroe added this pull request to the merge queue May 26, 2026

danielroe removed this pull request from the merge queue due to a manual request May 26, 2026

danielroe changed the title chore: use local fonts fix: use local font provider May 26, 2026

danielroe added this pull request to the merge queue May 26, 2026

Merged via the queue into npmx-dev:main with commit c757f1a May 26, 2026
25 checks passed

github-actions Bot mentioned this pull request May 26, 2026

chore: release v0.13.0 #2713

Merged

coderabbitai Bot mentioned this pull request Jun 2, 2026

fix(ui): render Geist consistently across Firefox and Chrome #2842

Merged

ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026

fix: use local font provider (npmx-dev#2803 )

1542330

Co-authored-by: Daniel Roe <daniel@roe.dev>

                     {
                       name: 'Geist Mono',
-                      weights: ['400', '500'],
-                      preload: true,

fix: use local font provider by alexdln · Pull Request #2803 · npmx-dev/npmx.dev · GitHub

Uh oh!

Uh oh!

fix: use local font provider - #2803

fix: use local font provider#2803danielroe merged 5 commits intonpmx-dev:mainnpmx-dev/npmx.dev:mainfrom alexdln:chore/local-geist-fontsalexdln/npmx.dev:chore/local-geist-fontsCopy head branch name to clipboard

Conversation

alexdln commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧭 Context

📚 Description

Uh oh!

vercel Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

mootari May 26, 2026

Choose a reason for hiding this comment

Uh oh!

alexdln May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 26, 2026

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

danielroe May 26, 2026

Choose a reason for hiding this comment

Uh oh!

alexdln May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: use local font provider#2803
danielroe merged 5 commits into
npmx-dev:mainfrom
alexdln:chore/local-geist-fonts

alexdln commented May 26, 2026 •
edited
Loading

vercel Bot commented May 26, 2026 •
edited
Loading

coderabbitai Bot commented May 26, 2026 •
edited
Loading

alexdln May 26, 2026 •
edited
Loading