FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: use monospace font in embed chart by graphieros · Pull Request #2857 · npmx-dev/npmx.dev · GitHub

/ npmx.dev Public

fix: use monospace font in embed chart - #2857

Merged
graphieros merged 1 commit into
mainfrom
embed-chart-font
Jun 5, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix: use monospace font in embed chart#2857
graphieros merged 1 commit into
mainfrom
embed-chart-font

Conversation

graphieros commented Jun 5, 2026

Copy link
Copy Markdown
Member

Follow up to #2833

Embedded charts currently have the default browser font, which does not convey the npmx design language.
This adds a style tag inside the svg to set the font-family of text elements to monospace.

vercel Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Preview, Comment Jun 5, 2026 9:39pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Jun 5, 2026 9:39pm
npmx-lunaria Ignored Jun 5, 2026 9:39pm

coderabbitai Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Need the big picture first? Review this PR in Change Stack to see what changed before going file by file.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: af98baad-98f6-40e1-9c0d-fe72acb06277

📥 Commits

Reviewing files that changed from the base of the PR and between eeacab3 and b0b866d.

📒 Files selected for processing (1)
  • server/utils/embed-downloads-svg.ts
📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Improved text rendering in downloaded SVG files by applying monospace font styling to labels and other text elements.

Walkthrough

An inline CSS style rule is added to the SVG response generator, setting all text elements to render in monospace font within the downloads visualisation.

Changes

SVG text monospace font styling

Layer / File(s) Summary
SVG text monospace styling
server/utils/embed-downloads-svg.ts		 The createDownloadsSvgResponse function now injects an inline <style> block (text {font-family:monospace;}) into the SVG markup, applying monospace font rendering to all text elements.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 4 ✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding monospace font styling to embedded charts.
Description check ✅ Passed The description clearly explains the purpose of the change, references a related issue, and describes the implementation approach.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch embed-chart-font

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

graphieros requested a review from a team June 5, 2026 21:44
graphieros enabled auto-merge June 5, 2026 21:44

ghostdevv commented Jun 5, 2026

Copy link
Copy Markdown
Member
Before: After:

(my monospace font is Comic Mono)

graphieros added this pull request to the merge queue Jun 5, 2026

ghostdevv commented Jun 5, 2026

Copy link
Copy Markdown
Member

We could also probably load the Geist font in the SVG

Merged via the queue into main with commit f5c28a4 Jun 5, 2026
28 checks passed
graphieros deleted the embed-chart-font branch June 5, 2026 22:11
github-actions Bot mentioned this pull request Jun 5, 2026
Merged
kimkanu pushed a commit to kimkanu/npmx.dev that referenced this pull request Jun 6, 2026
fix: use monospace font in embed chart (npmx-dev#2857)
ce93846
kimkanu pushed a commit to kimkanu/npmx.dev that referenced this pull request Jun 6, 2026
fix: use monospace font in embed chart (npmx-dev#2857)
de2ee09
kimkanu pushed a commit to kimkanu/npmx.dev that referenced this pull request Jun 6, 2026
fix: use monospace font in embed chart (npmx-dev#2857)
c16ee20
coderabbitai Bot mentioned this pull request Jun 7, 2026
Merged
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
fix: use monospace font in embed chart (npmx-dev#2857)
da87d26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ghostdevv ghostdevv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL