chore: enable fetch-depth for canary build by alexdln · Pull Request #2860 · npmx-dev/npmx.dev · GitHub

🔗 Linked issue

🧭 Context

From the logs, the problem of missed translations in canary is definitely in the lunaria/lunaria file, but nothing much has come up. So, as suggested in discord earlier, I'm trying to configure fetch depth. It seems even more likely that it's related to git

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Jun 6, 2026 8:17am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Jun 6, 2026 8:17am
npmx-lunaria	Ignored		Jun 6, 2026 8:17am

Too many files changed? Review this PR in Change Stack to see how the pieces fit before you dive in.

📝 Walkthrough

Summary by CodeRabbit

Chores
- Enhanced canary deployment workflow efficiency to optimise CI/CD performance.
- Modified error handling behaviour during canary deployments for improved reliability during testing phases.

Walkthrough

This pull request adjusts canary deployment handling across two areas: the CI workflow now limits git history depth to 2 commits during checkout, and the module's build error handling no longer re-throws errors when the canary environment encounters build failures, instead logging them via console.error.

Changes

Canary Deployment Adjustments

Layer / File(s)	Summary
Canary deployment workflow fetch configuration .github/workflows/deploy-canary.yml	The actions/checkout step is configured with fetch-depth: 2 to limit the git history depth checked out during canary deployments.
Canary error handling in module build modules/lunaria.ts	The Nitro build hook's error re-throw condition is updated to exclude env === 'canary', so canary environment build errors fall back to console.error logging instead of being re-thrown.

Possibly Related PRs

npmx-dev/npmx.dev#2848: Both PRs modify modules/lunaria.ts's error-handling logic in the nitro:build:before hook around the canary environment check.

Suggested Reviewers

trueberryless
ghostdevv

🚥 Pre-merge checks | ✅ 4 ✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: enabling fetch-depth configuration for the canary build workflow.
Description check	✅ Passed	The description is related to the changeset, providing context about debugging missed translations in canary builds and the rationale for configuring fetch depth.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

modules/lunaria.ts (1)

40-44: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Do not soft-fail Lunaria build errors on canary CI.

Swallowing this exception for env === 'canary' allows deployment to continue with potentially missing translation assets, which weakens canary as a safety signal.

Suggested fix

-          if (env === 'dev' || env === 'release') {
+          if (env === 'dev' || env === 'release' || env === 'canary') {
             throw e
           } else {
             console.error(e)
           }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@modules/lunaria.ts` around lines 40 - 44, The current error handling in
modules/lunaria.ts swallows Lunaria build exceptions for canary; update the
conditional that checks env so canary also throws instead of soft-failing —
locate the block that tests the env variable (referenced as env) and the thrown
exception e, and change the logic to throw e for 'dev', 'release' and 'canary'
(or invert to only swallow for explicit local/test envs) so CI will fail on
Lunaria build errors rather than logging them.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@modules/lunaria.ts`:
- Around line 40-44: The current error handling in modules/lunaria.ts swallows
Lunaria build exceptions for canary; update the conditional that checks env so
canary also throws instead of soft-failing — locate the block that tests the env
variable (referenced as env) and the thrown exception e, and change the logic to
throw e for 'dev', 'release' and 'canary' (or invert to only swallow for
explicit local/test envs) so CI will fail on Lunaria build errors rather than
logging them.

ℹ️ Review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1a396fcf-8aa1-43a2-8a77-5545b3cfcad2

📥 Commits

Reviewing files that changed from the base of the PR and between 396b17f and dcad029.

📒 Files selected for processing (2)

.github/workflows/deploy-canary.yml
modules/lunaria.ts

@ghostdevv It didn't help to fix the error too 🤔 But at least now there is no process errors

@ghostdevv It didn't help to fix the error too 🤔 But at least now there is no process errors

It does appear to be the same underlying error?

Error: fatal: not a git repository (or any parent up to mount point /vercel)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Error: Command failed: node --experimental-transform-types ./lunaria/lunaria.ts

Yes, now at least there is a full trace, but it turned out to be useless

chore: enable fetch-depth for canary build

dcad029

vercel Bot deployed to Preview – npmx.dev June 6, 2026 08:17 View deployment

coderabbitai Bot reviewed Jun 6, 2026

View reviewed changes

ghostdevv approved these changes Jun 6, 2026

View reviewed changes

ghostdevv added this pull request to the merge queue Jun 6, 2026

Merged via the queue into npmx-dev:main with commit d6b4f05 Jun 6, 2026
25 checks passed

github-actions Bot mentioned this pull request Jun 6, 2026

chore: release v0.16.0 #2856

Merged

alexdln deleted the chore/checkout-depth-canary branch June 6, 2026 15:38

shuuji3 mentioned this pull request Jun 17, 2026

feat(i18n): update Japanese translation #2902

Merged

ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026

chore: enable fetch-depth for canary build (npmx-dev#2860 )

62c1009

chore: enable fetch-depth for canary build by alexdln · Pull Request #2860 · npmx-dev/npmx.dev · GitHub

Uh oh!

Uh oh!

chore: enable fetch-depth for canary build - #2860

chore: enable fetch-depth for canary build#2860
ghostdevv merged 1 commit into
npmx-dev:mainfrom
alexdln:chore/checkout-depth-canary

alexdln commented Jun 6, 2026

Uh oh!

vercel Bot commented Jun 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

codecov Bot commented Jun 6, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

alexdln commented Jun 6, 2026

Uh oh!

ghostdevv commented Jun 6, 2026

Uh oh!

alexdln commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: enable fetch-depth for canary build by alexdln · Pull Request #2860 · npmx-dev/npmx.dev · GitHub

Uh oh!

Uh oh!

chore: enable fetch-depth for canary build - #2860

chore: enable fetch-depth for canary build#2860ghostdevv merged 1 commit intonpmx-dev:mainnpmx-dev/npmx.dev:mainfrom alexdln:chore/checkout-depth-canaryalexdln/npmx.dev:chore/checkout-depth-canaryCopy head branch name to clipboard

Conversation

alexdln commented Jun 6, 2026

🔗 Linked issue

🧭 Context

Uh oh!

vercel Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Possibly Related PRs

Suggested Reviewers

Uh oh!

codecov Bot commented Jun 6, 2026

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexdln commented Jun 6, 2026

Uh oh!

ghostdevv commented Jun 6, 2026

Uh oh!

alexdln commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: enable fetch-depth for canary build#2860
ghostdevv merged 1 commit into
npmx-dev:mainfrom
alexdln:chore/checkout-depth-canary

vercel Bot commented Jun 6, 2026 •
edited
Loading

coderabbitai Bot commented Jun 6, 2026 •
edited
Loading