| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
📝 Walkthrough
WalkthroughThis PR adds a new keyboard shortcut entry for opening the changelog. The AppFooter.vue shortcuts modal gains a - key row, the i18n schema defines a new shortcuts.section.changelog property, and translation strings are added in Arabic, English, Hindi, and Dutch locale files. ChangesChangelog keyboard shortcut
Possibly related PRs
Suggested reviewers: ghostdevv 🚥 Pre-merge checks | ✅ 4 ✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly. You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description. Tracked Files
|
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sorry, something went wrong.
There was a problem hiding this comment.
I assume you used AI to do the translations? Usually we prefer it if you only translate the languages you're familiar with as it's easier for people to add missing translations and fix broken ones (plus gives others a good way to contribute). Otherwise LGTM
Sorry, something went wrong.
Yes, I used AI to help with the translations. The change was very small, just replacing a few English text. I agree that native speakers are best suited for translation work, and I appreciate you pointing it out. I'll keep that in mind for future translation contributions. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looking good, but like what ghostdev said about the translations, at least in Dutch I localise it differently
Sorry, something went wrong.
| "settings": "Open instellingen", | ||
| "compare": "Open vergelijken", | ||
| "compare_from_package": "Vergelijking openen (vooraf ingevuld met het huidige pakket)", | ||
| "changelog": "Open changelog", |
There was a problem hiding this comment.
For Dutch this should be "Open wijzigingenoverzicht"
Also for languages you don't know I would suggest leaving them empty instead of "{open} changelog" as it can be that some languages will localise it differently compared to translating directly.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks!
I agree, I'll keep that in mind for future translation contributions.
Sorry, something went wrong.
There was a problem hiding this comment.
at least for Dutch looking good now, further reviewing I'll leave up to ghostdevv.
I'll also share this pr in the i18n channel in discord, maybe some from there will look at the translations
Sorry, something went wrong.
…context for new packages
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agentsVerify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/locales/cs-CZ.json`:
- Line 39: The cs-CZ translation for the "changelog" key is misleading ("Otevřít
změny nového balíčku"); update the value for the "changelog" entry in
i18n/locales/cs-CZ.json (key: "changelog") to a neutral phrase that reflects
opening the changelog for the current package, e.g., "Otevřít changelog" or
"Otevřít změny balíčku", ensuring it no longer implies the package is new.
In `@i18n/locales/zh-TW.json`:
- Line 39: The "changelog" translation value currently reads "開啟變更日誌(針對新套件)",
which implies the shortcut is only for new packages; update the value for the
"changelog" key to remove the misleading qualifier and use "開啟變更日誌" so it
correctly reflects opening the changelog for the current package; locate the
"changelog" key in i18n/locales/zh-TW.json and replace its value accordingly.
Fix all unresolved CodeRabbit comments on this PR:
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e56b936e-6688-486f-ac4c-b92f6f747ff2
📥 CommitsReviewing files that changed from the base of the PR and between 5ff06e6 and 710e3a6.
📒 Files selected for processing (9)
Sorry, something went wrong.
There was a problem hiding this comment.
I'd recommend to not adding translations for the languages you are not familiar with and wait until someone who does adds them later
Sorry, something went wrong.
I've removed the unverified translations and kept the change focused on the original fix. |
Sorry, something went wrong.
…2873) Co-authored-by: Your Name <your@email.com> Co-authored-by: Willow (GHOST) <git@willow.sh>
| Back | FazBrowse Home | New Git URL |
🔗 Linked issue
#2871
🧭 Context
The - shortcut for opening the changelog tab on package is shown in the UI but missing from the Keyboard Shortcuts search section.
📚 Description
The package page shows a - keyboard shortcut for opening the changelog, but this shortcut is not listed on the Keyboard shortcuts search section.