Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

shared/utils/download-chart-last-label.ts (2)

1-5: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update the JSDoc to describe the new collision-handling algorithm.

The comment still describes labels as "evenly distributed vertically", but the implementation now uses a different approach: labels are sorted by Y position, clamped to bounds, vertically separated by labelHeight, with overflow correction applied when the stack exceeds the drawing area.

📝 Suggested JSDoc update

 /**
  * Utility to be used in vue-data-ui line charts (`VueUiXy`) using the `#svg` slot to display the last value as data label.
- * In case of mutliple series, if label collisions are detected, labels are evenly distributed vertically,
- * and linked to the last datapoint with an elbowed marker
+ * In case of multiple series, if label collisions are detected, labels are positioned as close as possible to their datapoints,
+ * vertically separated to prevent overlaps, and linked to the datapoint with an elbowed connector.
  */

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@shared/utils/download-chart-last-label.ts` around lines 1 - 5, Update the
file-level JSDoc in shared/utils/download-chart-last-label.ts to describe the
current collision-handling algorithm: state that last-point labels are first
sorted by their computed Y position, each label Y is clamped to the drawing
bounds, adjacent labels are separated by a fixed vertical gap equal to
labelHeight, and if the stacked labels overflow the drawing area an
overflow-correction step shifts the whole stack to fit within the bounds;
mention that elbowed markers link labels to their datapoints and that these
adjustments run only when multiple series collide. Use the actual symbol names
used in the module (e.g., the function that computes positions) when referring
to the algorithm to make the docstring traceable.

---

1-5: ⚠️ Potential issue | 🟡 Minor

Update the “evenly distributed vertically” wording to match the actual last-label collision layout

app/components/Package/TrendsChart.vue still documents “labels are evenly distributed vertically”, but shared/utils/download-chart-last-label.ts:createLastDatapointLabelsSvg resolves collisions by sorting labels by their original y, clamping them to the drawing area, then stacking them to maintain at least labelHeight spacing (and shifting up if there’s overflow). Update the JSDoc in TrendsChart.vue (and ideally the shared utility) to describe this behaviour instead of “evenly distributed vertically”.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@shared/utils/download-chart-last-label.ts` around lines 1 - 5, Update the
JSDoc in app/components/Package/TrendsChart.vue (and the comment in
shared/utils/download-chart-last-label.ts) to replace “evenly distributed
vertically” with a precise description of the actual layout: state that
createLastDatapointLabelsSvg sorts labels by their original y, clamps them to
the drawing area, stacks them to maintain at least labelHeight spacing, and
shifts the stack upward if it overflows, and that each label is linked to its
last datapoint with an elbowed marker; mention the min-spacing/stack-and-shift
behaviour rather than claiming even vertical distribution.