FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: fix in invalid `firewall-version` in deploy-canary.yml by serhalp · Pull Request #2909 · npmx-dev/npmx.dev · GitHub

/ npmx.dev Public

ci: fix in invalid firewall-version in deploy-canary.yml - #2909

Merged
serhalp merged 1 commit into
mainfrom
serhalp/ci/fix-sfw-version
Jun 14, 2026
ConversationCommits (1)ChecksFiles changed
Merged

ci: fix in invalid firewall-version in deploy-canary.yml#2909
serhalp merged 1 commit into
mainfrom
serhalp/ci/fix-sfw-version

Conversation

serhalp commented Jun 14, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

🧭 Context

Follow-up to #2889.

The deploy-canary workflow (only runs on main) failed on merge: https://github.com/npmx-dev/npmx.dev/actions/runs/27503413651/job/81290268327.

The version needs to be specified without the v prefix.

This isn't well documented, but you can see it here: https://github.com/SocketDev/action/blob/ba6de6cc0565af1f42295590380973573297e31f/src/tools/firewall.js#L47.

📚 Description

Remove v prefix

ci: fix in invalid firewall-version in deploy-canary.yml
007d21f 
Follow-up to #2889.

The deploy-canary workflow (only runs on `main`) failed on merge:
https://github.com/npmx-dev/npmx.dev/actions/runs/27503413651/job/81290268327.

The version needs to be specified without the `v` prefix.

This isn't well documented, but you can see it here:
https://github.com/SocketDev/action/blob/ba6de6cc0565af1f42295590380973573297e31f/src/tools/firewall.js#L47.

vercel Bot commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Preview, Comment Jun 14, 2026 4:06pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Jun 14, 2026 4:06pm
npmx-lunaria Ignored Jun 14, 2026 4:06pm

serhalp requested a review from trueberryless June 14, 2026 16:04

coderabbitai Bot commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 010135f4-5548-4312-83c1-c396c0e7faf7

📥 Commits

Reviewing files that changed from the base of the PR and between 17b86f6 and 007d21f.

📒 Files selected for processing (1)
  • .github/workflows/deploy-canary.yml
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated canary deployment workflow configuration to standardise version format requirements, ensuring consistent version notation across deployment processes.

Walkthrough

The canary deployment workflow is updated to pass 1.12.0 instead of v1.12.0 as the firewall-version input to the SocketDev action, removing the leading v prefix. An adjacent comment is added to document that this input expects a version string without a v prefix.

Changes

Canary Workflow Version Format Fix

Layer / File(s) Summary
Remove v-prefix from firewall-version
.github/workflows/deploy-canary.yml		 firewall-version value changed from v1.12.0 to 1.12.0, with a comment clarifying the no-v-prefix format requirement.
🚥 Pre-merge checks | ✅ 4 ✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing an invalid firewall-version parameter in deploy-canary.yml by removing the v prefix.
Description check ✅ Passed The description is directly related to the changeset, providing context about the workflow failure, the root cause, and the solution implemented.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serhalp/ci/fix-sfw-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

serhalp enabled auto-merge June 14, 2026 16:05

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

trueberryless approved these changes Jun 14, 2026
View reviewed changes

trueberryless left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for not catching that.
Thanks for the quick fix.

serhalp added this pull request to the merge queue Jun 14, 2026
Merged via the queue into main with commit 604dc92 Jun 14, 2026
28 checks passed
serhalp deleted the serhalp/ci/fix-sfw-version branch June 14, 2026 16:13
github-actions Bot mentioned this pull request Jun 14, 2026
Merged
BittuBarnwal7479 pushed a commit to BittuBarnwal7479/npmx.dev that referenced this pull request Jun 27, 2026
ci: fix in invalid firewall-version in deploy-canary.yml (npmx-dev#…
f1b43a0 
…2909)
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
ci: fix in invalid firewall-version in deploy-canary.yml (npmx-dev#…
758f70b 
…2909)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

trueberryless trueberryless approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL