| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Corrects Dutch translation issues.
"wijzigingenoverzicht" is confusing for the end-user and "changelog" is a widely accepted term for this target group.
use formal pronouns, because its mostly used + translate chart
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
📝 Walkthrough
WalkthroughDutch locale strings are updated across command palette, package navigation, package stats, a new noodles section, compare labels, diff browser options, and privacy policy cookie text. ChangesDutch locale copy updates
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
|
Hello! Thank you for opening your first PR to npmx, @larsdouweschuitema! 🚀 Here’s what will happen next:
|
Sorry, something went wrong.
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly. You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description. Tracked Files
|
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sorry, something went wrong.
There was a problem hiding this comment.
In general good changes, only for "Changelog" & "Core" I do have suggested changes as I do think it's better to keep the English terms to a minimum.
also nice that you caught the informal translations as it should've been formal, at my work we use informal which makes it that when translating that I sometimes translate to informal instead of formal.
Sorry, something went wrong.
Change "Changelog" to "Wijzigingen Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
Change "changelog" to "Wijzigingen" Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
change "Core" to "Kern" Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
Change "core" to "kernlid" Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
Thanks for your review! I agree with all suggestions and resolved them. With regards to keeping Dutch at a minimum, I don't have a strong preference, but I can understand! |
Sorry, something went wrong.
Looks like there weren't many more changes since last review so we can merge this and fix anything in a follow up 😄
English* |
Sorry, something went wrong.
|
Thanks for your first contribution, @larsdouweschuitema! 💫 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
Sorry, something went wrong.
| "load_more": "Laad nog {count}", | ||
| "dates": "Actieve datums", | ||
| "shipped_in": "Uitgebracht in", | ||
| "credits": "Credits", |
There was a problem hiding this comment.
nl: In de volgende pr misschien dit veranderen naar "Ontworpen door" i.p.v. "Credits"
en: in the next pr maybe replace this with "Ontworpen door" instead of "Credits"
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah looks good in general, did find out that the casing for "Wijzigingen" is correct compared to the other tabs and I've a comment for "credits".
Further it looks all good
Also maybe an idea could be to have a monthly cycle with updating nl.json to where a draft pr is created every month and then in the last week of the month it's opened for review.
this could allow while a pr is in draft to update it in smaller chunks instead of needing to update all new additions in a short amount of time, it could also allow for discussion in cases of being unsure about something.
Sorry, something went wrong.
I generally try to reduce open PRs in favour of quicker more focused ones as there is a lot of activity on the repo and I don't want them to go stale or have duplicates. That being said, if you want to do it go for it, we do have that stale bot now anyway - also, I'm happy to tag you for reviews on Dutch related PRs we get if you like! since I don't speak Dutch the best I can do is run it through a translator to make sure there's nothing obviously wrong, but it's always great if we have native speakers that we know (we can't tell if it's been translated, or clanked) to make sure we don't have mistakes - currently there's no process for tagging people for this though |
Sorry, something went wrong.
Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
🔗 Linked issue
No open issue related to Dutch translations.
🧭 Context
Dutch language contains incorrect and missing translations.
📚 Description
All translations were reviewed and manually tested in a local environment.