Zero CI. The repo advertises engines: >=18.17 and a npm test flow, but nothing verifies either — there is no pipeline, no green-badge trust signal, and a regression can land silently. (The Node 18 leg matters: until now npm test silently broke on Node 18 because node --test glob expansion is a Node 21+ feature — verified on a real Node 18.20.8 install. This PR stacks on the CLI-contract fix that replaces the glob with a cross-version runner.)
The published package ships test source. Without a files whitelist, npm publish packs src/, tests/, scripts/, .github/ and dist/tests/ — and the package has no exports map, no repository metadata, no keywords, and declares MIT with no LICENSE file.
Changes
CI (.github/workflows/ci.yml)
Matrix: Node 18 / 20 / 22 / 24 × ubuntu / windows / macos — the exact engine floor from engines plus current LTS lines, on every OS the CLI targets.
Runs npm ci, npm test, plus offline-demo and --version smoke checks.
Separate package hygiene job: npm pack --dry-run prints the tarball contents so a wrong files whitelist fails loudly.
fail-fast: false so one platform's failure doesn't mask the others.
Publish hygiene (package.json)
files: ["dist/src", "README.md", "LICENSE"] — the tarball drops from ~everything to 60 files / 49 kB (verified via npm pack --dry-run): compiled JS + d.ts + maps only, no tests or sources.
exports map (types / import / default) so TS consumers and bundlers resolve the package deterministically.
keywords, repository, bugs, homepage, sideEffects: false, and prepublishOnly: npm run build so a stale dist can never be published.
LICENSE
Adds the MIT text that package.json already declares but never shipped. Copyright line uses the repo owner handle (nullcache) — adjust the holder name if you prefer a legal name.
Verification
npm test: 26/26 pass on Node 24 and on Node 18.20.8 (the engines floor).
Note: this PR stacks on the CLI-contract PR (it replaces the Node 21+ glob in npm test with a cross-version runner, which is why Node 18 can be in the CI matrix here). Merge order: CLI-contract first, or both together — the commit history is clean either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this is core
Two market-facing gaps in one PR:
Zero CI. The repo advertises engines: >=18.17 and a npm test flow, but nothing verifies either — there is no pipeline, no green-badge trust signal, and a regression can land silently. (The Node 18 leg matters: until now npm test silently broke on Node 18 because node --test glob expansion is a Node 21+ feature — verified on a real Node 18.20.8 install. This PR stacks on the CLI-contract fix that replaces the glob with a cross-version runner.)
The published package ships test source. Without a files whitelist, npm publish packs src/, tests/, scripts/, .github/ and dist/tests/ — and the package has no exports map, no repository metadata, no keywords, and declares MIT with no LICENSE file.
Changes
CI (.github/workflows/ci.yml)
Publish hygiene (package.json)
LICENSE
Verification