FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Give the LLM client a request timeout so a hung provider can't stall the agent by uuzzrm · Pull Request #6 · nullcache/corecoder-ts · GitHub

Give the LLM client a request timeout so a hung provider can't stall the agent - #6

Merged
nullcache merged 3 commits into
nullcache:mainfrom
uuzzrm:fix/llm-request-timeout
Aug 17, 2026
Merged

Give the LLM client a request timeout so a hung provider can't stall the agent#6
nullcache merged 3 commits into
nullcache:mainfrom
uuzzrm:fix/llm-request-timeout

Conversation

uuzzrm commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Was running this against a flaky proxy the other day and hit something annoying: the agent would just sit there — no output, nothing. Turns out fetch() doesn't have a timeout. Node silently drops the timeout option if you pass it, so if a provider accepts the connection and then never answers, you're stuck until you hit Ctrl+C.

So the LLM client now takes a timeoutMs (default 5 min, overridable with CORECODER_TIMEOUT_MS) and every request races against a timer. If the timer wins, it aborts the fetch and the retry loop treats it as a transient error and retries. Your own Ctrl+C still comes through as an AbortError — the timeout can't swallow it.

Three tests cover it:

  • a provider that hangs forever → request times out, retry loop gives up with a "timed out" error
  • a pre-aborted signal → still surfaces as AbortError, not a timeout
  • first attempt times out, second succeeds → retry works

Writing the tests caught something fun: my fetch stub didn't reject when handed an already-aborted signal, so the second test hung forever. Real fetch rejects immediately in that case, so I fixed the stub, not the client.

Design note: the timeout covers getting a response, not the streaming body — a model that's actively streaming can legitimately take a while, and that's Ctrl+C territory. Say the word if you'd rather have a whole-call timeout instead.

uuzzrm and others added 3 commits August 15, 2026 10:55
The manual merge of main mistyped the env parsing lines:
',' became '||' (dropping the fallback argument), temperature
used intFromEnv instead of floatFromEnv, and one call was
misspelled as pintFromEnv. Restore the intended calls, with
timeoutMs also validated via intFromEnv.
nullcache force-pushed the fix/llm-request-timeout branch from c2f8d21 to 7bca881 Compare August 17, 2026 03:24
nullcache merged commit 42e04cb into nullcache:main Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL