BUG: fix integer size confusion in handling array's ndmin argument - #14937
Merged
charris merged 1 commit intoNov 19, 2019
Merged
charris merged 1 commit into
charris merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The ndmin local variable was changed from an "int" to an "npy_intp" but &ndmin is passed to PyArg_ParseTupleAndKeywords against a "i" argument spec, but these integers have different sizes (well on an LP64 platform anyway). This actually works on a little endian system but fails on a big endian one. Fix this by converting the local back to an int, and being a little careful before assigning the result of PyLong_AsLong to it. Fixes numpy#14767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14769.
The ndmin local variable was changed from an "int" to an "npy_intp" but
&ndmin is passed to PyArg_ParseTupleAndKeywords against a "i" argument
spec, but these integers have different sizes (well on an LP64 platform
anyway). This actually works on a little endian system but fails
on a big endian one. Fix this by converting the local back to an int,
and being a little careful before assigning the result of PyLong_AsLong to
it.
Fixes #14767