MAINT: Add missing placeholder annotations - #18302
Merged
charris merged 4 commits intoFeb 2, 2021
Merged
charris merged 4 commits into
charris merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
added 4 commits
February 1, 2021 18:16
* `fromarrays` * `fromrecords` * `fromstring` * `fromfile` * `array`
Copy link
Copy Markdown
Member
|
It would be best if you made the backport PRs. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Will do; I'll create the backport after this PR has been merged. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks Bas. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds (placeholder) annotations for a few objects that were missed in #17104.
In the wake of #18270 I did a double check of all placeholder annotations and identified a few
that were previously missing, mostly module-level __all__ attributes.
In addition there were two groups of public functions that were missing from their module's __all__.
This has now been rectified: