FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: Change license date 2020 -> 2021 by dmontesl · Pull Request #18346 · numpy/numpy · GitHub

/ numpy Public

DOC: Change license date 2020 -> 2021 - #18346

Merged
seberg merged 2 commits into
numpy:masterfrom
dmontesl:patch-1
Feb 6, 2021
Merged

seberg merged 2 commits into
numpy:masterfrom
dmontesl:patch-1

Conversation

dmontesl commented Feb 6, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

A very small contribution to update the license date from 2020 to 2021 :)

mattip commented Feb 6, 2021

Copy link
Copy Markdown
Member

There is one more in the copyright notice in doc/source/conf.py

mattip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

charris added this to the 1.20.1 release milestone Feb 6, 2021

seberg commented Feb 6, 2021

Copy link
Copy Markdown
Member

Interesting, the travis CI here also failed with the 16 byte alignment error I saw on my PR https://travis-ci.com/github/numpy/numpy/jobs/480993160#L4095

  numpy/core/src/multiarray/_multiarray_tests.c.src: In function ‘call_npy_cargl’:
4095  numpy/core/src/multiarray/_multiarray_tests.c.src:2000:9: note: the ABI of passing aggregates with 16-byte alignment has changed in GCC 5
4096           npy_@name@@suffix@(*(@itype@*)PyArray_DATA((PyArrayObject *)z_arr));
4097           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4098

obviously unrelated, but does anyone know what this is?

charris commented Feb 6, 2021

Copy link
Copy Markdown
Member

That question was answered before, apparently it means that compiled code is not binary compatible between gcc 5 and gcc 4.

seberg commented Feb 6, 2021

Copy link
Copy Markdown
Member

Oh, had not seen that. Makes sense, so we just don't worry about it and ignore these warnings when they crop up?

charris commented Feb 6, 2021

Copy link
Copy Markdown
Member

Found the explanation at #18220 (comment)

seberg commented Feb 6, 2021

Copy link
Copy Markdown
Member

Thanks @Aerysv. And thanks Chuck, sorry for missing that.

gh-18349 should fix the circleci failure, no need to wait for this here though I think.

seberg merged commit 62b8296 into numpy:master Feb 6, 2021
charris pushed a commit to charris/numpy that referenced this pull request Feb 7, 2021
A very small contribution to update the license date from 2020 to 2021 :)
charris removed the 09 - Backport-Candidate PRs tagged should be backported label Feb 7, 2021
charris removed this from the 1.20.1 release milestone Feb 7, 2021
dmontesl deleted the patch-1 branch February 7, 2021 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL