MAINT: crackfortran regex simplify - #18356
Merged
charris merged 2 commits intoFeb 7, 2021
Merged
charris merged 2 commits into
charris merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* remove extraneous character class markers used in `crackline_re_1`: `\w` and `=` on their own have no benefit to character class `[]` inclusion * `name_match` has a character class that can be simplified because `\w` metacharacter already encompasses the digit metacharacter and the underscore
* `name_match` regular expression now starts by matching a letter only, based on reviewer feedback
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18072.
remove extraneous character class markers used in
crackline_re_1: \w and = on their own have no
benefit to character class [] inclusion
name_match has a character class that can be
simplified because \w metacharacter already
encompasses the digit metacharacter and the
underscore