FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MAINT, CI: treats _SIMD module build warnings as errors through CI only by charris · Pull Request #18924 · numpy/numpy · GitHub

/ numpy Public

MAINT, CI: treats _SIMD module build warnings as errors through CI only - #18924

Merged
charris merged 1 commit into
numpy:maintenance/1.20.xfrom
charris:backport-18903
May 6, 2021
ConversationCommits (1)ChecksFiles changed
Merged

MAINT, CI: treats _SIMD module build warnings as errors through CI only#18924
charris merged 1 commit into
numpy:maintenance/1.20.xfrom
charris:backport-18903

Conversation

charris commented May 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Partial backport of #18903.

Closes #18297

charris added 03 - Maintenance 08 - Backport Used to tag backport PRs labels May 5, 2021
charris added this to the 1.20.3 release milestone May 5, 2021

seiko2plus commented May 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@charris, #18903 comes with "two" commits the first one is the only matter to backport. if you think it necessary to get both patches then we will need to backport #17791 too or maybe just remove export CFLAGS="$CFLAGS -Werror=undef" from the second patch.

charris commented May 6, 2021

Copy link
Copy Markdown
Member Author

@seiko2plus Thanks for the info, it saved me from needing to look for the missing PR :) Backports become trickier towards the end of the support window.

charris commented May 6, 2021

Copy link
Copy Markdown
Member Author

Lets try with just the first patch. I confess I don't see what is does :)

seiko2plus commented May 6, 2021

Copy link
Copy Markdown
Member

I confess I don't see what is does :)

LOL, I think it's just fine to have only this patch.

charris merged commit c447619 into numpy:maintenance/1.20.x May 6, 2021
charris deleted the backport-18903 branch May 7, 2021 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

03 - Maintenance 08 - Backport Used to tag backport PRs component: numpy._core

Projects

None yet

Milestone

1.20.3 release

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL