MAINT: Mark npy_memchr with no_sanitize("alignment") on clang - #21467
Merged
charris merged 1 commit intoMay 9, 2022
Merged
charris merged 1 commit into
charris merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Clangs sanitizer reports unaligned access here, which is correct but intentional. It may well be that the code would be better of trying to avoid this unaligned access (and rather vectorizing harder). But, this is a bit of a tricky choice, since we have to optimize for different use-cases (in particular very short scans may be interesting). So changing this would best be done together with some more careful benchmarks. See also numpygh-21117, which introduced manual loop unrolling to avoid the unaligned access. Closes numpygh-21116
seberg
force-pushed
the
mark-no-sanitize-on-npy-memchr
branch
from
bc1efb3 to
3257ab0
Compare
May 6, 2022 13:42
Copy link
Copy Markdown
Member
|
Thanks Sebastian. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clangs sanitizer reports unaligned access here, which is correct
but intentional. It may well be that the code would be better of
trying to avoid this unaligned access (and rather vectorizing harder).
But, this is a bit of a tricky choice, since we have to optimize for
different use-cases (in particular very short scans may be interesting).
So changing this would best be done together with some more careful
benchmarks.
See also gh-21117, which introduced manual loop unrolling to avoid the
unaligned access.
Closes gh-21116