BUG: Fix GCC error during build configuration - #21534
Merged
seberg merged 1 commit intoMay 18, 2022
Merged
seberg merged 1 commit into
seberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
GCC 11 fails the configuration test for detecting `strtold_l` when the `-Wall` flag is present because `-Werror=nonnull` is activated. The fix is to add a pragma to `numpy/core/feature_detection_locale.h` to ignore that error. Closes numpy#21529.
Copy link
Copy Markdown
Member
|
OK, lets just do it. It seems plausible that clang also understands the pragma, and at least for long double MSVC should be a non-issue. Thanks Chuck! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 11 fails the configuration test for detecting strtold_l when the
-Wall flag is present because -Werror=nonnull is activated. The fix
is to add a pragma to numpy/core/feature_detection_locale.h to ignore
that error.
Closes #21529.