FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DEP: drop older cygwin compatibility shims by mattip · Pull Request #22159 · numpy/numpy · GitHub

/ numpy Public

DEP: drop older cygwin compatibility shims - #22159

Merged
rgommers merged 2 commits into
numpy:mainfrom
mattip:cygwin-versions
Aug 21, 2022
Merged

rgommers merged 2 commits into
numpy:mainfrom
mattip:cygwin-versions

Conversation

mattip commented Aug 21, 2022

Copy link
Copy Markdown
Member

Continuation of #22139, see this comment

xref @DWesl

mattip added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Aug 21, 2022
mattip removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Aug 21, 2022

DWesl commented Aug 21, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

It will probably be clearer to refer to Cygwin 3.3 rather than Cygwin DLL major version 3003, at least in the release notes, since the first one is what uname -r and the package manager show. Otherwise looks good.

DWesl commented Aug 21, 2022

Copy link
Copy Markdown
Contributor

It looks like the Azure failure amounts to "Azure had problems". The changes look good.

rgommers added this to the 1.24.0 release milestone Aug 21, 2022

rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM too, in it goes. Thanks @mattip, and thanks @DWesl for the review.

rgommers merged commit a36783e into numpy:main Aug 21, 2022
mattip deleted the cygwin-versions branch December 27, 2022 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL