FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MAINT: removing the deprecated submodule by bsipocz · Pull Request #23809 · numpy/numpy · GitHub

/ numpy Public

MAINT: removing the deprecated submodule - #23809

Merged
seberg merged 3 commits into
numpy:mainfrom
bsipocz:remove_umath_tests_deprecation
May 29, 2023
ConversationCommits (3)ChecksFiles changed
Merged

MAINT: removing the deprecated submodule#23809
seberg merged 3 commits into
numpy:mainfrom
bsipocz:remove_umath_tests_deprecation

Conversation

bsipocz commented May 25, 2023

Copy link
Copy Markdown
Member

The functionality has been made private a while ago, and it's probably time to remove the submodule.

seberg approved these changes May 28, 2023
View reviewed changes

seberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, LGTM either way. I had misunderstood that we even had a python stub without the underscore...

Comment thread numpy/core/_add_newdocs.py
DOC: Updating example
86d6970 
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
seberg merged commit 413835b into numpy:main May 29, 2023

bsipocz commented May 29, 2023

Copy link
Copy Markdown
Member Author

I had misunderstood that we even had a python stub without the underscore...

The beauty of collecting all docstrings for testing 🙂

bsipocz commented May 30, 2023

Copy link
Copy Markdown
Member Author

Does this need a mention in the release docs? I wasn't sure how pedantic it should be.

seberg commented May 30, 2023

Copy link
Copy Markdown
Member

Oh, forgot, could add a bullet point into expired category. But I don't care, this is niche, since the "test" in the name should give idea...

bsipocz mentioned this pull request Jun 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

seberg seberg approved these changes

Assignees

No one assigned

Labels

03 - Maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL