MAINT: Make numpy.fft.helper private - #24945
ngoldbaum merged 2 commits into
Conversation
Sorry, something went wrong.
ngoldbaum
left a comment
There was a problem hiding this comment.
Just one super minor comment, other than that this looks good to me.
Sorry, something went wrong.
|
|
||
| from .arrayterator import Arrayterator | ||
| from ._version import * | ||
| from .introspect import * |
There was a problem hiding this comment.
I just double-checked, there's no need to modify __getattr__ below since np.lib.opt_func_info hasn't made it into a release yet.
Sorry, something went wrong.
|
|
||
| from . import _pocketfft, helper | ||
| from . import _pocketfft, _helper | ||
| from . import helper # TODO: to be deleted once people move to `np.fft` |
There was a problem hiding this comment.
This comment should say it's deprecated in Numpy 2.0, following similar comments in the codebase so it's greppable.
Sorry, something went wrong.
There was a problem hiding this comment.
Sure! I updated the comment.
Sorry, something went wrong.
Hi @rgommers @ngoldbaum,
I started working on post-core-rename items to finalize NEP 52 (one thing is making sure with a test that each function is available from one place only).
In this PR I make numpy.fft.helper private (now numpy.fft._helper) as it defines four public functions that are already available from numpy.fft.
I think that helper is used a bit, therefore I left a stub that raises a warning on access. If you would like a more strict approach here (only an AttributeError) let me know!