MAINT: Update environment.yml to match *_requirements.txt - #25308
rgommers merged 2 commits into
Conversation
Sorry, something went wrong.
rgommers
left a comment
There was a problem hiding this comment.
Thanks Melissa. This doesn't look quite right to me. The single = is the correct comparison symbol, == is not correct. Semantics are not the same compared to PyPI/pip specifiers (e.g., this will install 3.11.0 rather than 3.11.6). The added exact pins are not desired I think.
The only change that seems okay to make here is Python 3.11.x instead of 3.9.x
Sorry, something went wrong.
|
Of course you're right, sorry about that ! |
Sorry, something went wrong.
| - openblas | ||
| - nomkl | ||
| - setuptools=59.2.0 | ||
| - setuptools |
There was a problem hiding this comment.
Do we still need to explicitly list setuptools at all?
Sorry, something went wrong.
There was a problem hiding this comment.
We still have some compile tests using setup.py (e.g. _core/tests/test_limited_api.py), so it makes sense. setuptools is installing with python by conda anyway, so in practice it doesn't matter much.
Sorry, something went wrong.
rgommers
left a comment
There was a problem hiding this comment.
LGTM now, thanks Melissa.
Sorry, something went wrong.
No real reason other than I noticed the docs were being built locally on python 3.9 instead of 3.11, which is used in CI. If any of those are incorrect please let me know.