| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Could use a release note, as it is a behavior change. |
Sorry, something went wrong.
|
Added a release note and a test. The test doesn't really cover the motivating issue here, as rational does not inherit from np.number, but it's better than nothing. It may be worth adding some sort of test-only custom float type to better cover this sort of issue, but I'll punt on that for now. |
Sorry, something went wrong.
|
There’s also the scaled float test dtype using the new dtype system. I want to add numpy-user-dtypes as a test-only dependency to make it easier to test stuff like this. |
Sorry, something went wrong.
|
The behavior change seems fine to me and reads like what the code intended beyond that no one expected someone to write a user dtype set up like bfloat16. |
Sorry, something went wrong.
|
Close/reopen. The test failure looks unrelated, but I would like to know what is going on. |
Sorry, something went wrong.
|
@jakevdp Could you try rebasing on current master to see if that fixes the build failure on CircleCI? |
Sorry, something went wrong.
The current approach can result in a misleading repr() for user-defined dtypes. For example, a bfloat16 scalar type that inherits from np.number and sets dtype.kind='f' will be displayed as dtype('float16'). We can circumvent this by handling user-defined dtypes first.
|
rebased |
Sorry, something went wrong.
|
@jakevdp Thanks, that fixed the build. There was still an undefined reference, which I have fixed. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The current approach can result in a misleading repr() for user-defined dtypes. For example, a bfloat16 scalar type that inherits from np.number and sets dtype.kind='f' will be displayed as dtype('float16') rather than dtype(bfloat16). We can circumvent this by handling user-defined dtypes first.