SIMD: Fix Highway QSort symbol linking error on aarch32/ASIMD - #28671
Merged
seiko2plus merged 1 commit intoApr 9, 2025
Merged
seiko2plus merged 1 commit into
seiko2plus merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The fix in numpy/meson#12 for ASIMD*(32-bit) compile-time feature detection revealed a new build error on aarch32 platforms: ImportError: /numpy/build-install/usr/lib/python3/dist-packages/numpy/_core/ _multiarray_umath.cpython-310-arm-linux-gnueabihf.so: undefined symbol: _ZN2np7highway10qsort_simd11QSort_ASIMDIjEEvPT_i This patch prevents platform detection constants of Highway from being exposed across translation units with different compiler flags (baseline). This approach eliminates detection mismatches that were causing symbol resolution failures in the Highway QSort implementation.
seiko2plus
force-pushed
the
fix_highway_qsort_arm32
branch
from
6d9a2b1 to
d634e51
Compare
April 8, 2025 11:48
Mousius
approved these changes
Apr 8, 2025
Mousius
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It's a bit unfortunate to have the extra levels of indirection, but I think fixing the symbol issue takes precedence 😸
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Thanks for review. Agreed. Ideally we'd avoid dispatching when VQSORT_ENABLED is false, but the current fix still lets the compiler optimize better than the baseline flags. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in numpy/meson#12 for ASIMD*(32-bit) compile-time feature detection revealed a new
build error on aarch32 platforms:
This patch prevents platform detection constants of Highway from being exposed across
translation units with different compiler flags (baseline). This approach
eliminates detection mismatches that were causing symbol resolution failures
in the Highway QSort implementation.
relates numpy/meson#12