BUG: handle case in mapiter where descriptors might get replaced (#29286) - #29287
Merged
charris merged 2 commits intoJun 28, 2025
Merged
charris merged 2 commits into
charris merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…py#29286) Need to use the actual dtype, not the one passed to the array creation (because it can get replaced). Fixes numpy#29279.
seberg
reviewed
Jun 28, 2025
Comment thread
numpy/_core/src/multiarray/alloc.c
| #endif | ||
| #endif | ||
| #ifndef USE_ALLOC_CACHE | ||
| #define USE_ALLOC_CACHE 1 |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Ah, thanks for fixing this warning! Is this already in main?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
No :) I fixed it because the 3.13t smoke test was failing, which was new.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
PR incoming.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29286.
Need to use the actual dtype, not the one passed to the array creation (because it can get replaced).
Fixes #29279.