BUG: np.einsum() fails with a 0-dimensional out argument and optimize='optimal' - #31354
Merged
seberg merged 3 commits intoApr 28, 2026
Merged
BUG: np.einsum() fails with a 0-dimensional out argument and optimize='optimal'#31354seberg merged 3 commits into
seberg merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
seberg
approved these changes
Apr 28, 2026
seberg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, small nit, but I think it is also good as is.
Sorry, something went wrong.
Comment thread
numpy/_core/tests/test_einsum.py
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
krivenko
force-pushed
the
einsum-0d-out-optimize
branch
from
d108479 to
5ea7e7c
Compare
April 28, 2026 14:15
Copy link
Copy Markdown
Contributor
Author
|
@seberg There was a missing : in the change you suggested, so I had to amend that commit... |
Sorry, something went wrong.
seberg
reviewed
Apr 28, 2026
Comment thread
numpy/_core/tests/test_einsum.py
Outdated
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
charris
pushed a commit
that referenced
this pull request
Apr 28, 2026
…='optimal' (#31354) It replaces the expression out[:] found in bmm_einsum() with the more universal out[...], which is also valid for a 0-dimensional out. TestEinsum.test_einsum_misc() in numpy/_core/tests/test_einsum.py has been extended. Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
charris
added a commit
that referenced
this pull request
Apr 28, 2026
BUG: np.einsum() fails with a 0-dimensional out argument and optimize='optimal' (#31354)
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
May 7, 2026
…='optimal' (numpy#31354) It replaces the expression out[:] found in bmm_einsum() with the more universal out[...], which is also valid for a 0-dimensional out. TestEinsum.test_einsum_misc() in numpy/_core/tests/test_einsum.py has been extended. Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR fixes #31350.
It replaces the expression out[:] found in bmm_einsum() with the more universal out[...], which is also valid for a 0-dimensional out.
TestEinsum.test_einsum_misc() in numpy/_core/tests/test_einsum.py has been extended to cover #31350.
First time committer introduction
I am a researcher who uses NumPy in a multitude of scientific computing projects, mostly simulation codes for computational condensed matter theory. I discovered the issue #31350 while working on one of such (private) projects.
AI Disclosure
No AI has been used in preparation of this PR.