| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I included the crasher that @jeromekelleher provided in gh-31415 as a test. By increasing n_cols to 10, I could get the crash to occur with high probability even with the duration of the test reduced to 2 seconds. Still, I'm not sure we want to include this in the test suite. |
Sorry, something went wrong.
|
Thanks for the speedy fix @WarrenWeckesser ❤️ |
Sorry, something went wrong.
We may want to have a multi-threaded test, but not with explicit time.sleep(2). There must be better patterns already in the test suite already, probably @ngoldbaum can point at an example here. |
Sorry, something went wrong.
Was just confirming that it works: But we don't need any threading at all. We just need to add a parametrization for existing tests with >500 elements or so (let's do 2000 maybe). We have debug test runs in the test-suite, and these already hit it reliably, the only problem is that the tests don't cover larger tests. |
Sorry, something went wrong.
Which tests are those? |
Sorry, something went wrong.
|
The TestStringLikeCasts will do the trick (we use it for bytes casting). EDIT: E.g. ["short", "12345678"] * 1000, works... |
Sorry, something went wrong.
This case is a regression test for numpygh-31415 when run in a debug build.
|
I removed the multi-threaded test and added the test case suggested by @seberg. |
Sorry, something went wrong.
|
Thanks Warren! |
Sorry, something went wrong.
|
@ngoldbaum, thanks for finding my mistake 😳. |
Sorry, something went wrong.
|
No problem, I really appreciate you taking on the fix :) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Remove incorrect calls of Py_INCREF(descr) and Py_DECREF(descr) in the RAII object NpyStringAcquireAllocator.
Closes gh-31415.
AI Disclosure
No AI tools used.