FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FIX: bug in np.where and recarray swapping by certik · Pull Request #395 · numpy/numpy · GitHub

/ numpy Public

FIX: bug in np.where and recarray swapping - #395

Merged
certik merged 1 commit into
numpy:masterfrom
certik:fix369
Aug 31, 2012
ConversationCommits (1)ChecksFiles changed
Merged

FIX: bug in np.where and recarray swapping#395
certik merged 1 commit into
numpy:masterfrom
certik:fix369

Conversation

certik commented Aug 30, 2012

Copy link
Copy Markdown
Contributor

Fixes #369 and the Ticket 2185

FIX: bug in np.where and recarray swapping
ecbd938 
Fixes numpy#369 and the Ticket 2185

Thanks to @seberg for providing the patch.

travisbot commented Aug 30, 2012

Copy link
Copy Markdown

This pull request passes (merged 6e82fd31 into 5c944b9).

travisbot commented Aug 30, 2012

Copy link
Copy Markdown

This pull request passes (merged ecbd938 into 5c944b9).

njsmith commented Aug 30, 2012

Copy link
Copy Markdown
Member

Looks sensible to me.

seberg reviewed Aug 31, 2012
View reviewed changes
Comment thread numpy/core/tests/test_regression.py

seberg Aug 31, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure if it matters or is the case. But it may be necessary to test both '>' and '<' for big-endian machines where I guess the singletons should be big endian? would be just a second net here and a second test below (unless there is a way to make net non-native).

certik Aug 31, 2012

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would you mind sending a PR for this please? I am going to merge this issue now.

certik mentioned this pull request Aug 31, 2012
Closed

certik commented Aug 31, 2012

Copy link
Copy Markdown
Contributor Author

Got reviewed by @njsmith, merging.

certik added a commit that referenced this pull request Aug 31, 2012
Merge pull request #395 from certik/fix369
8c75aa0 
FIX: bug in np.where and recarray swapping
certik merged commit 8c75aa0 into numpy:master Aug 31, 2012
certik mentioned this pull request Sep 16, 2012
Merged
This was referenced Oct 16, 2012
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in numpy.where

4 participants

Back | FazBrowse Home | New Git URL