FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BUG: Add a test for Ticket #2189 by certik · Pull Request #397 · numpy/numpy · GitHub

/ numpy Public

BUG: Add a test for Ticket #2189 - #397

Merged
certik merged 2 commits into
numpy:masterfrom
certik:fix2189
Sep 2, 2012
ConversationCommits (2)ChecksFiles changed
Merged

BUG: Add a test for Ticket #2189#397
certik merged 2 commits into
numpy:masterfrom
certik:fix2189

Conversation

certik commented Aug 31, 2012

Copy link
Copy Markdown
Contributor

This fixes: http://projects.scipy.org/numpy/ticket/2189

(after this PR is merged, the ticket can be closed)

travisbot commented Aug 31, 2012

Copy link
Copy Markdown

This pull request passes (merged 137f25fd into 5c944b9).

certik mentioned this pull request Aug 31, 2012
Closed

certik commented Aug 31, 2012

Copy link
Copy Markdown
Contributor Author

@njsmith, if you have a minute, can you please review this PR?

travisbot commented Aug 31, 2012

Copy link
Copy Markdown

This pull request passes (merged cb5a27e into e60c70d).

travisbot commented Aug 31, 2012

Copy link
Copy Markdown

This pull request passes (merged 0713354 into e60c70d).

njsmith reviewed Sep 1, 2012
View reviewed changes
Comment thread numpy/core/tests/test_regression.py

njsmith Sep 1, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The use of format_parser is pretty pointless here, it's equivalent to just writing a = np.recarray((2,), "i4, i4") or a = np.recarray((2,), [("", "i4"), ("", "i4")])... doesn't really matter much though.

njsmith commented Sep 1, 2012

Copy link
Copy Markdown
Member

Sure, it looks fine (modulo the nitpick mentioned above, which you can fix if you feel like it, or not...).

certik commented Sep 2, 2012

Copy link
Copy Markdown
Contributor Author

I personally like the test, as it tests the reported issue directly. It shouldn't cause any problems. So I am merging this.

certik added a commit that referenced this pull request Sep 2, 2012
Merge pull request #397 from certik/fix2189
7d30cad 
BUG: Add a test for Ticket #2189
certik merged commit 7d30cad into numpy:master Sep 2, 2012
certik mentioned this pull request Sep 16, 2012
Merged
This was referenced Oct 16, 2012
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL