FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BUG: Fix ticket #1588/gh issue #398, refcount error in clip by mwiebe · Pull Request #400 · numpy/numpy · GitHub

/ numpy Public

BUG: Fix ticket #1588/gh issue #398, refcount error in clip - #400

Closed
mwiebe wants to merge 1 commit into
numpy:maintenance/1.7.xfrom
mwiebe:fix_clip_refcount
ConversationCommits (1)ChecksFiles changed
Closed

BUG: Fix ticket #1588/gh issue #398, refcount error in clip#400
mwiebe wants to merge 1 commit into
numpy:maintenance/1.7.xfrom
mwiebe:fix_clip_refcount

Conversation

mwiebe commented Aug 31, 2012

Copy link
Copy Markdown
Member

This hopefully does the trick, it fixes the crash for me.

This patch enforces a strict dichotomy for the variables 'indescr'
and 'newdescr', so they are either NULL, or they own a reference.
Following the consequences of this allowed the reference error
to be tracked down.

BUG: Fix ticket numpy#1588/gh issue numpy#398, refcount error in clip
ef09361 
This patch enforces a strict dichotomy for the variables 'indescr'
and 'newdescr', so they are either NULL, or they own a reference.
Following the consequences of this allowed the reference error
to be tracked down.

travisbot commented Aug 31, 2012

Copy link
Copy Markdown

This pull request fails (merged ef09361 into ea23de8).

njsmith commented Aug 31, 2012

Copy link
Copy Markdown
Member

Looks fine to me. The test failure is because separate compilation is broken on maintenance/1.7.x in general -- someone should fix that... I think there's a patch in master.

certik commented Aug 31, 2012

Copy link
Copy Markdown
Contributor

I think that this patch should go into master, right?

mwiebe commented Aug 31, 2012

Copy link
Copy Markdown
Member Author

Yeah, should be applied in master too.

certik commented Aug 31, 2012

Copy link
Copy Markdown
Contributor

And also a test needs to be written. I'll send a PR with your patch and a test against master, and only after it's in, I'll backport it to the release branch. There is more stuff to be backported anyway.

certik mentioned this pull request Aug 31, 2012
Merged

certik commented Aug 31, 2012

Copy link
Copy Markdown
Contributor

I am closing this in favor of #405.

certik closed this Aug 31, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL