add option x-go-allof-embed-refs - #1295
Closed
lahabana wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This is useful when working with extending APIs Signed-off-by: Charly Molter <charly.molter@konghq.com>
Copy link
Copy Markdown
Author
|
There seems to be more recent options |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when working with extending APIs
I'm opening this as draft as it's missing:
This is useful for us as we have apis that expand APIs already defined externally. This enables us to avoid a lot of mapping code.
I didn't want to extend old-merge-schemas as this seems likely to be removed in the future.
We handle the original issue by just refusing the generate go code which would result in a non openAPI compliant (which was the original motivation for not using embedded objects ref: #531)
Signed-off-by: Charly Molter charly.molter@konghq.com