Optional response header - #1412
Closed
ShouheiNishi wants to merge 9 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ers are exist in Iris strict server.
…is is generate as pointer type. When this field is nil, corresponding header is not set in functions Visit*.
ShouheiNishi
marked this pull request as ready for review
December 28, 2023 04:16
Copy link
Copy Markdown
Member
|
Thank you for submitting this PR, @ShouheiNishi — but we need to close it because it has been superseded by #2301 (commit a4c36dc2), which landed all three elements you proposed: pointer types for optional headers (*T via GoTypeDef() in pkg/codegen/operations.go), nil-guards on w.Header().Set() in the strict-server templates, and a HeadersImplicitlyRequired compatibility flag for users relying on the old behavior. The originally-linked issue #1301 is now fixed. Apologies for the long wait. We really do appreciate the contribution — it pointed at the right problem and the right shape of fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix issue #1301, when header is optional, field for this is generate as pointer type. When this field is nil, corresponding header is not set in functions Visit*.
However, this change introduce some incompatibility.
So we add compatibility option.
And this PR included PR #1411.