fix(array-pointer): support array pointer for ref - #2073
Open
zdunecki wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Kusari Analysis Results:
No pinned version dependency changes, code issues or exposed secrets detected!
Found this helpful? Give it a 👍 or 👎 reaction! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There's a fix for this case:
components: schemas: response.Placeholder: x-go-embedding: true type: object allOf: - $ref: "#/components/schemas/Response" - type: object properties: hello: type: string past_7_days_histogram: type: array x-go-type-skip-optional-pointer: true nullable: true items: allOf: - $ref: '#/components/schemas/DateHistogram' DateHistogram: type: object properties: key: type: string key_as_string: type: string nullable: true doc_count: type: integerI would expect it will produce in Go code like that:
type ResponsePlaceholder struct { Hello *string `json:"hello,omitempty"` Past7DaysHistogram []*DateHistogram `json:"past_7_days_histogram"` }The key is - []*DateHistogram.
Currently, it's not possible to declare type: array with an external $ref and a pointer(*). I tried multiple ways and still get []DateHistogram.
This PR should fix that.
Best,