feat: #1536 add sprig template functions - #2110
Open
phoenisx wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Before I get a chance to properly review, can you please make sure the original author is given a Co-authored-by in the commit please? Given this is their work, it'd be good to make sure that's retained |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I would love to add Co-authored-by, but there are no changes from the original PR. I raised this (and found an existing PR) today, because I was facing issues creating my own custom template and found there was an open discussion on sprig library. In case you still want me to add them as co-author, please do let me know, will update my commit message I updated the commit message 💯 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1536
This is a new PR for previously opened PR: #1582, integrating all go template functions from sprig library.