FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: use go mod tidy instead of tidied by alexandear · Pull Request #2482 · oapi-codegen/oapi-codegen · GitHub

chore: use go mod tidy instead of tidied - #2482

Merged
jamietanna merged 1 commit into
oapi-codegen:mainfrom
alexandear-org:chore/go-mod-tidy
Jul 17, 2026
Merged

chore: use go mod tidy instead of tidied#2482
jamietanna merged 1 commit into
oapi-codegen:mainfrom
alexandear-org:chore/go-mod-tidy

Conversation

Copy link
Copy Markdown
Contributor

The tidied is not needed, since we have go mod tidy -diff. From https://gitlab.com/jamietanna/tidied:

alexandear requested a review from a team as a code owner July 17, 2026 19:36
Comment thread Makefile Outdated

greptile-apps Bot commented Jul 17, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR replaces the external tidy checker with Go's built-in tidy diff mode. The main changes are:

  • Root tidy-ci now runs go mod tidy -diff.
  • Example module tidy-ci now runs go mod tidy -diff.
  • Internal test module tidy-ci now runs go mod tidy -diff.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
Makefile Updates the root check-only tidy target while leaving the mutating tidy target unchanged.
examples/Makefile Updates the examples module check-only tidy target to use Go's built-in diff mode.
internal/test/Makefile Updates the internal test module check-only tidy target to use Go's built-in diff mode.

Reviews (3): Last reviewed commit: "chore: use go mod tidy instead of tidied" | Re-trigger Greptile

Comment thread Makefile Outdated
alexandear requested a review from jamietanna July 17, 2026 20:51

jamietanna commented Jul 17, 2026
edited
Loading

Copy link
Copy Markdown
Member

Per Greptile - does this run go mod tidy then exit if its out of sync, or only checks if it's out of sync?

Edit: rereviewing should be OK as tidy-ci only affected

Copy link
Copy Markdown
Member

jamietanna merged commit 3eef009 into oapi-codegen:main Jul 17, 2026
14 checks passed
alexandear deleted the chore/go-mod-tidy branch July 18, 2026 10:16
jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL