| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Greptile SummaryThe PR replaces the earlier external-reference work with a focused strict JSON response fix.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains, and the previously reported external-reference issue is avoided because the focused replacement no longer changes externalref.go. Important Files Changed
Reviews (2): Last reviewed commit: "test: cover strict JSON response receive..." | Re-trigger Greptile |
Sorry, something went wrong.
|
This also fixes #2525, which @mromaszewicz filed during review of #2522 (same bug as #1328). I was about to start on it and found this PR instead, so I took it for a spin rather than duplicate the work. I merged the branch onto current main and generated strict-server code for every shape from #2525: schema: {}, type: "null", a 3.1 multi-type union, and a $ref to a named union component. Each one produces the Body wrapper and compiles, with the ref case classified by its underlying schema. Regenerating the committed fixtures on the merged tree produces no diff, so the output is consistent with the generator after #2522 and #2526. Two non-blocking suggestions:
Neither should hold this up. The wrapper shape matches what #2525 proposes, and wrapping only receiver-incompatible bodies keeps the direct API for everything that compiles today. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Scope
Testing
AI assistance
This change was developed with AI assistance.
Fixes #1328