FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci(readme-toc): use our `go.mod` for installing `go` version by jamietanna · Pull Request #2547 · oapi-codegen/oapi-codegen · GitHub

ci(readme-toc): use our go.mod for installing go version - #2547

Merged
jamietanna merged 1 commit into
mainfrom
ci/no-go-version
Aug 28, 2026
Merged

ci(readme-toc): use our go.mod for installing go version#2547
jamietanna merged 1 commit into
mainfrom
ci/no-go-version

Conversation

Copy link
Copy Markdown
Member

As we don't need to specify an explicit Go version, we can instead rely
on our go.mod's go (or toolchain) directives to enforce this.

This then avoids us getting unnecessary Go version bumps.

As we don't need to specify an explicit Go version, we can instead rely
on our `go.mod`'s `go` (or `toolchain`) directives to enforce this.

This then avoids us getting unnecessary Go version bumps.
jamietanna requested a review from a team as a code owner August 28, 2026 06:59

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates the README table-of-contents workflow to derive its Go toolchain version from the repository’s root go.mod instead of maintaining a separate hard-coded version.

  • Replaces go-version: "1.26" with go-version-file: 'go.mod'.
  • Keeps the workflow’s toolchain aligned with the module’s declared Go version.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The workflow deterministically selects Go 1.25.0 from the unchanged root module, and its sole Go-installed prerequisite supports that toolchain.

Important Files Changed

Filename Overview
.github/workflows/readme-toc.yml The workflow now selects Go 1.25.0 from the root module; this remains compatible with the README TOC tool’s Go 1.22 minimum.

Reviews (1): Last reviewed commit: "ci(readme-toc): use our `go.mod` for ins..." | Re-trigger Greptile

jamietanna merged commit 74122c0 into main Aug 28, 2026
32 checks passed
jamietanna deleted the ci/no-go-version branch August 28, 2026 07:25
jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL