fix: strip style prefix for label/matrix primitive parameters (#99) - #100
Merged
mromaszewicz merged 1 commit intoMar 12, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…odegen#99) BindStyledParameterWithOptions passed the raw styled value directly to BindStringToObject for primitive types, without first removing the style prefix. This caused label (leading ".") and matrix (";param=") styles to fail with parse errors for non-struct, non-slice destinations. Route primitive values through splitStyledParameter — the same function already used by the struct and slice paths — so the prefix is stripped before binding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mromaszewicz
force-pushed
the
fix/issue-99
branch
from
7ad6ecd to
0759bf5
Compare
March 3, 2026 17:48
jamietanna
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BindStyledParameterWithOptions passed the raw styled value directly to BindStringToObject for primitive types, without first removing the style prefix. This caused label (leading ".") and matrix (";param=") styles to fail with parse errors for non-struct, non-slice destinations.
Route primitive values through splitStyledParameter — the same function already used by the struct and slice paths — so the prefix is stripped before binding.