feat: support spaceDelimited and pipeDelimited query parameter binding - #117
Merged
mromaszewicz merged 2 commits intoApr 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Implement deserialization for spaceDelimited and pipeDelimited query parameter styles in both BindQueryParameterWithOptions and BindRawQueryParameter. For explode=true, these styles are serialized identically to form explode=true (each value is a separate key=value pair), so they share the same code path. For explode=false, the values are split on their style-specific delimiter (space or pipe) instead of comma. The BindRawQueryParameter implementation handles all space representations (%20, +, and literal space) for spaceDelimited. Fixes oapi-codegen#116 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ry params Export RequiredParameterError so generated server code can use errors.As to detect missing required parameters and produce framework-specific typed errors for application error handlers. Previously these were plain fmt.Errorf strings that couldn't be distinguished from format errors without string matching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member
|
Would this be for the 1.4.0 milestone, no? (As it's a new feature, I'd expect a minor bump) |
Sorry, something went wrong.
jamietanna
approved these changes
Apr 8, 2026
Copy link
Copy Markdown
Member
Author
|
Yes, it's for 1.4.0 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a concrete error type for missing required parameters.
Implement deserialization for spaceDelimited and pipeDelimited query parameter styles in both BindQueryParameterWithOptions and BindRawQueryParameter.
For explode=true, these styles are serialized identically to form explode=true (each value is a separate key=value pair), so they share the same code path. For explode=false, the values are split on their style-specific delimiter (space or pipe) instead of comma.
The BindRawQueryParameter implementation handles all space representations (%20, +, and literal space) for spaceDelimited.
Fixes #116