Improve deepobject unmarshalling to support nullable.Nullable and encode.TextUnmarshaler - #45
Merged
mromaszewicz merged 5 commits intoMar 30, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 3 commits
May 23, 2024 10:43
Specifically, types that there are special edge-cases for
…marshalling # Conflicts: # deepobject.go # deepobject_test.go
Remove nullable.Nullable deep object support (moved to separate repo). Move TextUnmarshaler check into case reflect.Struct after the legacy Date/time.Time handlers, so it catches types like uuid.UUID without intercepting time.Time date-only fallback parsing. Add early returns to the Date and time.Time blocks which previously fell through. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member
|
This is an old PR, sorry for getting to it after such a long time. I'm going to edit your PR to remove the nullable stuff, since it's no longer relevant, and resolve the conflicts and clean up the rest. This will amount to only adding the marshaler path. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Oh, bummer, the repo is archived, I can't do that. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi, thank you for getting to this - apologies, I'd archived all my non-active public repos. I've unarchived it now |
Sorry, something went wrong.
mromaszewicz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44.
This adjusts deep object unmarshalling to support types that implement encoding.TextUnmarshaler (which fixes the issue with with unmarshalling uuid.UUID, and is an interface that is commonly implemented by other types). I'm aware that the Binder interface exists however most types from common libraries don't/won't implement it.
It also adjust deep object marshalling to support nil types, marshalling them as field=null rather than field=.
Finally, it adds custom unmarshalling for the nullable.Nullable type. I'm not 100% happy with how I've done this, with the nullableLike interface, however because nullable.Nullable is generic it's tricky to use casting/reflection to determine the type.