fix: make BindQueryParameter play along with x-go-type-skip-optional-pointer - #47
Merged
mromaszewicz merged 1 commit intoJul 9, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mromaszewicz
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run into the same issue as described in oapi-codegen/oapi-codegen#1344 with in: query parameters annotated with x-go-type-skip-optional-pointer extension.
I was a bit surprised at the beginning because codegen generates the code with plain struct field (i.e. skips pointer) as expected in the query string params struct but fails with panic during runtime. Turns out it wasn't that hard to fix and it seems am useful addition for users that desire zero values for optional parameters instead of pointers with nil value to communicate lack of parameter.