FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix BindQueryParameter for optional parameters by TelpeNight · Pull Request #48 · oapi-codegen/runtime · GitHub

Fix BindQueryParameter for optional parameters - #48

Merged
mromaszewicz merged 1 commit into
oapi-codegen:mainfrom
TelpeNight:fix-opt-query-params
Jul 9, 2024
Merged

Fix BindQueryParameter for optional parameters#48
mromaszewicz merged 1 commit into
oapi-codegen:mainfrom
TelpeNight:fix-opt-query-params

Conversation

Copy link
Copy Markdown
Contributor

Hi. Latest commit introduced new error.
I've added test cases, that won't pass on current main branch.
The reason is that k := t.Kind() is String after passing through the else statement.

TelpeNight requested a review from a team as a code owner July 9, 2024 19:12
mromaszewicz merged commit 912bc9f into oapi-codegen:main Jul 9, 2024

Copy link
Copy Markdown
Contributor

sorry for breaking things :D

jamietanna added the bug Something isn't working label Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL