fix: improve email validation using net/mail package - #60
Merged
mromaszewicz merged 3 commits intoFeb 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Invalid emails no longer persist their value after failed UnmarshalJSON validation, since the new net/mail-based validation sets the value only after successful parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mromaszewicz
approved these changes
Feb 24, 2026
mromaszewicz
enabled auto-merge (squash)
February 24, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📧 Improve email validation using net/mail instead of regex
Context
Currently, our email validation is using a regex pattern that doesn't fully support all valid email separators according to RFC 5322. This PR replaces it with Go's built-in net/mail.ParseAddress which properly handles all valid email characters.
Changes
Before
The current regex validation fails with valid email addresses containing special characters like +, {, }, ~, * etc.
Example of a valid email that was incorrectly rejected:
validemail+with_valid-separator{like}~these*ones@openapicodegen.com ❌
After
Using net/mail.ParseAddress, we now correctly validate emails containing all RFC 5322 compliant characters:
validemail+with_valid-separator{like}~these*ones@openapicodegen.com ✅
This change makes our email validation more robust and standards-compliant while actually simplifying the code by leveraging Go's standard library.
Would love to get this merged to improve our validation capabilities! Let me know if you'd like any changes or have questions. 🚀