fix: respect Binder interface for primitive types in BindStringToObject - #86
Merged
mromaszewicz merged 2 commits intoFeb 28, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously, the Binder interface was only checked within the struct case of the type switch, causing primitive types (strings, ints, etc.) that implement Binder to bypass their custom binding logic. This fix moves the Binder check to the beginning of BindStringToObject, ensuring all types implementing Binder use their custom Bind method, regardless of their underlying type. The redundant check in the struct case has been removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
|
@jamietanna could this be looked at? We ran into a similar issue, and it'd mean we don't need to modify the template, nor use a fork to get this behavior, which would be ideal. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
cc @mromaszewicz we can take a look at this one after your current batch of changes are merged :) |
Sorry, something went wrong.
mromaszewicz
approved these changes
Feb 27, 2026
Copy link
Copy Markdown
Member
|
This looks great. Please rebase, and CI should pass, then we can merge. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looks like CI requires an approval to run |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Binder interface was only checked within the struct case of the type switch, causing primitive types (strings, ints, etc.) that implement Binder to bypass their custom binding logic. This fix moves the Binder check to the beginning of BindStringToObject, ensuring all types implementing Binder use their custom Bind method, regardless of their underlying type. The redundant check in the struct case has been removed.