[SYCLomatic] Refine the parameter_wrapper_t to support virtual pointer arithmetic for non-USM - #1844
Merged
zhimingwang36 merged 6 commits intoApr 3, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…r arithmetic for non-USM Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
zhiweij1
commented
Apr 1, 2024
Comment thread
clang/runtime/dpct-rt/include/dpct/blas_utils.hpp
Outdated
zhiweij1
commented
Apr 1, 2024
Comment thread
clang/runtime/dpct-rt/include/dpct/blas_utils.hpp
Outdated
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
tomflinda
approved these changes
Apr 1, 2024
tomflinda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
ziranzha
approved these changes
Apr 2, 2024
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
zhimingwang36
approved these changes
Apr 3, 2024
zhimingwang36
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…to test more cases (oneapi-src#667) Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiang, Zhiwei zhiwei.jiang@intel.com