[SYCLomatic] Remove invalid json test for standard compilation db fields - #583
[SYCLomatic] Remove invalid json test for standard compilation db fields#583daiyaan-ahmed6 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Signed-off-by: Ahmed, Daiyaan <daiyaan.ahmed@intel.com>
zhimingwang36
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
| if "directory_placeholder" in line: | ||
| ret.append(" \"output\": \"aaaaa\",\n") | ||
| line = line.replace("directory_placeholder", os.getcwd().replace("\\", "\\\\")) | ||
| iter += 1 |
There was a problem hiding this comment.
Sine 'Output' and 'Arguments' in compile_commands.json could be consumed by SYCLomatic, the test case should keep 'output' in compile_commands.json and also added 'Arguments' to verify this feature, instead of remove them.
Sorry, something went wrong.
There was a problem hiding this comment.
In the new PR for this, I have changed the name of these tests to 'standard_compilation_db_json' and I am keeping 'Arguments' and 'Output' in compilation db to verify that dpct consumes these arguments.
Sorry, something went wrong.
Removed tests are check for 'Output' and 'Arguments' field in dpct to be invalid.
This is done for passing of feature PR: oneapi-src/SYCLomatic#1566
ngt-invalid-json7 and ngt-invalid-json8 test are removed.
ngt-invalid-json9 and ngt-invalid-json10 are renamed to ngt-invalid-json7 and ngt-invalid-json8 respectively.
Signed-off-by: Daiyaan Ahmed daiyaan.ahmed@intel.com