Repository navigation
Address concerns raised with previous pull request - #2763
Merged
chuanyuf merged 1 commit intoJul 11, 2026
Merged
chuanyuf merged 1 commit into
chuanyuf merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: Charles Congdon <charles.w.congdon@intel.com>
AdityaKulshrestha
pushed a commit
to AdityaKulshrestha/oneAPI-samples
that referenced
this pull request
Aug 4, 2026
…260_feedback_updates Address concerns raised with pull request oneapi-src#2762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Fixed issues raised in code review (syntax errors, unused queue properties, device assumptions. Did leave an attempt to free a null pointer because the code will have already crashed trying to reference it.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?